Send user's auth token along with URL when opening Capture Club from App#784
Merged
Conversation
shc261392
suggested changes
Jul 16, 2021
Contributor
shc261392
left a comment
shc261392
left a comment
There was a problem hiding this comment.
There are a few places that could be changes. They're minor but should improve the coding style a bit. It's open for discussion if you have any other ideas.
I didn't test out this changes, so if you follow these changes please test it again to make sure the functionality doesn't change.
shc261392
approved these changes
Jul 16, 2021
This was referenced Dec 1, 2021
This was referenced Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check that whether I misused the RxJS operators, it's my first time using them.