Skip to content

Fix migrating set has prefetch corner case#490

Merged
shc261392 merged 6 commits into
developfrom
fix-migrating-set-has-prefetch-corner-case
Jan 27, 2021
Merged

Fix migrating set has prefetch corner case#490
shc261392 merged 6 commits into
developfrom
fix-migrating-set-has-prefetch-corner-case

Conversation

@shc261392
Copy link
Copy Markdown
Contributor

@shc261392 shc261392 commented Jan 27, 2021

Fix the following conditions:

  • If an error happens during migrating, the migration dialog will not be closed.
  • If an error happens during migrating, theHAS_PREFETCHED_DIA_BACKEND_ASSETS preference will not be set to true while it should.
  • If network is not connected (assuming that user is using the App offline), the migrating dialog will prompt and disappear everytime the user navigates to the home page.
  • If an error happens during pre-fetching, the pre-fetching dialog will not be closed.

@shc261392
Set hasPrefetched true before migrating starts
23f4871 
Signed-off-by: James Chien <shc261392@gmail.com>
@shc261392
Remove unused hasMigrate$
47080e3 
Signed-off-by: James Chien <shc261392@gmail.com>
@shc261392
Fix bad error handling during migration
b8453f9 
- Dialog will be properly closed if migration fails

- Migration dialog will not appear everytime navigating to the home page
  if the network is not connected

Signed-off-by: James Chien <shc261392@gmail.com>
@shc261392
Close the dialog when prefetching throws error
89dd594 
Signed-off-by: James Chien <shc261392@gmail.com>
@shc261392 shc261392 requested a review from seanwu1105 January 27, 2021 05:10
seanwu1105
seanwu1105 approved these changes Jan 27, 2021
View reviewed changes
Comment thread src/app/features/home/onboarding/prefetching-dialog/prefetching-dialog.component.ts Outdated
Comment thread src/app/shared/services/migration/migration.service.ts
@shc261392 shc261392 merged commit dbe5820 into develop Jan 27, 2021
@shc261392 shc261392 deleted the fix-migrating-set-has-prefetch-corner-case branch January 27, 2021 06:35
seanwu1105 added a commit that referenced this pull request Jan 28, 2021
@seanwu1105
Revert "Merge pull request #490 from numbersprotocol/fix-migrating-se…
8b41181 
…t-has-prefetch-corner-case"

This reverts commit dbe5820, reversing
changes made to 1616e12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seanwu1105 seanwu1105 seanwu1105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shc261392 @seanwu1105