WIP: Error handling rework #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramnes
reviewed
Jul 31, 2019
| @@ -77,6 +74,7 @@ def _send(self, send_method, service_name, data=None, **kwargs): | |||
| """ | |||
| valid_response = False | |||
| raw = kwargs.pop("raw", False) | |||
| custom_exception_handlers = kwargs.pop("custom_exception_handlers") | |||
There was a problem hiding this comment.
Suggested change
| custom_exception_handlers = kwargs.pop("custom_exception_handlers") | |
| custom_exception_handlers = kwargs.pop("custom_exception_handlers", None) |
ramnes
reviewed
Jul 31, 2019
| raise self.error_codes[error_code](response) | ||
| if "error_code" in data or "error_id" in data: | ||
| raise AppNexusException(response) | ||
| raise type(data["error_id"], (AppNexusException,), {})(response) |
There was a problem hiding this comment.
No need to create a new type if we catch it right after. Let's remove that method and check the "error_id" directly in an handle_errors method.
ramnes
reviewed
Jul 31, 2019
|
|
||
| def _exception_handler(self, exception, | ||
| response, data, | ||
| custom_handler=None): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.