Experiment: Add example CMake and meson build files #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should these be checked in CI? |
code-experiments/build/c/meson.build
Outdated
| default_options: ['warning_level=3', 'buildtype=release'] | ||
| ) | ||
|
|
||
| add_languages('c') |
There was a problem hiding this comment.
The idiomatic way to add a language is in the project function.
project('example_experiment', 'c', default_options: ['warning_level=3'])(Hmm, why isn't the cmake build also setting -Wall -Wextra -Wpedantic?)
There was a problem hiding this comment.
Thanks for the feedback! Changed the language specification to the more idiomatic way. Also tried to add warnings to the CMakeLists.txt, but afaik there's no easy and compiler agnostic way to do this.
olafmersmann
force-pushed
the
ome-c-build-options
branch
3 times, most recently
from
0f8c4c5
to
1f51c8f
Compare
olafmersmann
force-pushed
the
ome-c-build-options
branch
from
1f51c8f
to
40fc1ba
Compare
nikohansen
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake and meson are build systems that have both gained popularity. This PR adds example build files for both so that users might use them as starting points if their project already uses CMake or meson. It should also be a good option for users on Windows where CMake can generate Visual Studio project files.