Experiment: Lots of small C code fixes #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these were found using static analysis. Change should not result in any functional changes, just cleaner code.
coco_get_biobj_problem could return invalid results for invalid function indexes. Instead, raise a coco_error().
coco_error() never returns by calling exit(). Let the compiler know that coco_error() cannot return to improve the results from static analysis.
paulduf
reviewed
Feb 16, 2022
code-experiments/src/coco.h
Outdated
| @@ -465,7 +465,7 @@ void coco_free_memory(void *data); | |||
| /** | |||
| * @brief Signals a fatal error. | |||
| */ | |||
| void coco_error(const char *message, ...); | |||
| void coco_error(const char *message, ...) __attribute__((noreturn)) __attribute__((__noreturn__)); | |||
There was a problem hiding this comment.
This seems to be the culprit for the AppVeyor failure
There was a problem hiding this comment.
I've hidden the attributes behind macros which are defined based on the used compiler. Let's hope this fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small code fixes to catch more edge cases, remove dead code.