arraymath: add temporal scalar support for np reduction functions - #10533
Merged
Merged
Conversation
Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
swap357
reviewed
Apr 13, 2026
swap357
left a comment
swap357
left a comment
Contributor
There was a problem hiding this comment.
Thank you @amishhaa for the PR and tests. I've left some initial review comments below
esc
requested changes
Apr 15, 2026
Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
Signed-off-by: Amisha Chhajed <amishhhaaaa@gmail.com>
swap357
changed the title
swap357
reviewed
Apr 22, 2026
swap357
left a comment
swap357
left a comment
Contributor
There was a problem hiding this comment.
I've reviewed it again, looks very good now, thanks. :) The tests are all added and green. I've updated the title as well. I'll do one more pass little later to see if everything is working as it should be.
Contributor
Author
|
@swap357 okay thank you! |
swap357
approved these changes
Apr 27, 2026
swap357
left a comment
swap357
left a comment
Contributor
There was a problem hiding this comment.
Reviewed again, looks good. Thanks for the contribution, @amishhaa much appreciated! If you'd like to pick up something else, please feel free to go through issue tracker. There's #4074, that tracks missing NumPy overloads if you're after more in this area.
esc
approved these changes
Apr 28, 2026
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10522.
Part of #10408.
Added support to handle Temporal scalar types for np.min, np.max and np_all