Roundtrip llvmlite.binding.TypeRef back into llvmlite.ir.Type #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing indentation
Member
Author
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for exposing this interface @sklam, it is just what is needed for numba/pixie#21. A single typo else looks good. Thanks again!
| self.assertEqual(got, ty) | ||
| self.assertIsInstance(got, irtype) | ||
|
|
||
| def _check_typeref_as_ir_for_wrappers(self, asm, target_symbol): |
Contributor
There was a problem hiding this comment.
This is great, thanks!
Co-authored-by: stuartarchibald <[email protected]>
stuartarchibald
approved these changes
Jun 10, 2024
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch and fixes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
llvmlite.binding.TypeRef.as_ir()to extractllvmlite.ir.Type. This is useful for building wrappers around functions emitted by other LLVM-IR producing tools. See new tests that uses output from clang on C++ sources.