Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Heex commentstring + why does Comment.nvim re-implement Neovim's 'commentstring' options? #497

Open
mawkler opened this issue Nov 29, 2024 · 0 comments

Comments

@mawkler
Copy link
Contributor

mawkler commented Nov 29, 2024

I noticed that the Heex filetype uses the invalid comment style <!-- %s --> instead of <%!-- %s --%>. I went digging and found out that Neovim does in fact have the correct commentstring specified. Then I found that the problem is that this plugin has its own hard-coded commentstrings per filetype, and the Heex one is incorrect. Why does Comment.nvim re-implement commenstring when Neovim already has the specifications built-in?

I understand that Comment.nvim might want to specify the blockwise comment styles, since Neovim doesn't support those natively, but how come the linewise commentstrings are also hard-coded? Can't Comment.nvim just rely on Neovim's commentstrings?

mawkler added a commit to mawkler/nvim that referenced this issue Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant