[BUG] api.uncomment.linewise.* give error when nothing to uncomment

[bew]

Plugin version: 728f38e

Using following config:

require('Comment').setup {
  mappings = {
    extended = true
  }
}

Given some file foo.c:

abc

With the cursor on the line, using g<c will give the following error:

E5108: Error executing lua Vim(lua):E5108: Error executing lua ...m-wip/managed-plugins/Comment.nvim/lua/Comment/utils.lua:65: attempt to get length of local 'iter' (a nil value)
stack traceback:
        ...m-wip/managed-plugins/Comment.nvim/lua/Comment/utils.lua:65: in function 'is_empty'
        ...m-wip/managed-plugins/Comment.nvim/lua/Comment/utils.lua:297: in function 'uncomment'
        ...-wip/managed-plugins/Comment.nvim/lua/Comment/opfunc.lua:176: in function 'linewise'
        ...-wip/managed-plugins/Comment.nvim/lua/Comment/opfunc.lua:68: in function 'opfunc'
        ...vim-wip/managed-plugins/Comment.nvim/lua/Comment/api.lua:284: in function 'current'
        [string ":lua"]:1: in main chunk
        [C]: at 0x004609a0
stack traceback:
        [C]: at 0x004609a0

[numToStr]

I would say that it's not a bug to uncomment a line which is not commented to begin with, but the panic makes it look like one.

[bew]

Yeah it's definitely useless, but can happen by mistake.. I think it should just do nothing

[numToStr]

To make this nicer I have to add checks in multiple places that's why left the panic as it is. But I'll think about it as I might also need to handle some other cases as well.

[winkee01]

I have encountered the same issue.

[numToStr]

FYI, extended keybindings are deprecated 20772ed but that is not an excuse to hide the underlying issue which is with API itself. I am going fix the panics sooner or later.

[bew]

Great, thanks 😀👍