Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

### What's done: run benedikt on pull request too #3

Closed
wants to merge 21 commits into from
Closed

### What's done: run benedikt on pull request too #3

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6bfd081
### What's done: run benedikt on pull request too
nulls Dec 15, 2023
02cb2df
a fake change in Test.kt
nulls Dec 15, 2023
75c949a
Merge remote-tracking branch 'nulls/master' into feature/nulls/test
nulls Dec 18, 2023
ee5a6ce
changed reporter type
nulls Dec 18, 2023
bad3faf
changed version of benedikt
nulls Dec 18, 2023
f6e6d8d
changed version of benedikt
nulls Dec 18, 2023
8d10ccc
changed version of benedikt
nulls Dec 18, 2023
02d5bfc
changed version of benedikt
nulls Dec 18, 2023
3f11fe8
changed version of benedikt
nulls Dec 18, 2023
447daf8
changed version of benedikt
nulls Dec 18, 2023
f646065
changed version of benedikt
nulls Dec 18, 2023
1532521
changed version of benedikt
nulls Dec 18, 2023
bb18cc2
changed version of benedikt + sarif reporter
nulls Dec 18, 2023
4fd0753
changed version of benedikt
nulls Dec 18, 2023
11c7fbf
changed version of benedikt
nulls Dec 18, 2023
2eb71ce
changed version of benedikt
nulls Dec 18, 2023
d665d5d
changed version of benedikt
nulls Dec 18, 2023
2054775
changed version of benedikt
nulls Dec 18, 2023
d645fa4
test invalid reporter
nulls Dec 18, 2023
0bd0a44
Update .github/workflows/benedikt.yml
nulls Dec 19, 2023
58c5f25
Update .github/workflows/benedikt.yml
nulls Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/benedikt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Benedikt

on:
workflow_dispatch:
pull_request:

jobs:
diktat_check:
Expand All @@ -11,7 +12,8 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: nulls/benedikt@5c2b431b3a7a567d9103b917fcf520f78e2cc899
- uses: saveourtool/benedikt@v2
with:
reporter: test
nulls marked this conversation as resolved.
Show resolved Hide resolved
input-paths: |
examples/**/*.kt
4 changes: 2 additions & 2 deletions examples/gradle-groovy-dsl/src/main/kotlin/Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package incorrect

class incorrectname: Exception() {
class incorrectname3: Exception() {

Check failure

Code scanning / ktlint

[MISSING_KDOC_TOP_LEVEL] all public and internal top-level classes and functions should have Kdoc: incorrectname3 (cannot be auto-corrected) Error

[MISSING_KDOC_TOP_LEVEL] all public and internal top-level classes and functions should have Kdoc: incorrectname3 (cannot be auto-corrected)

Check failure

Code scanning / ktlint

[CLASS_NAME_INCORRECT] class/enum/interface name should be in PascalCase and should contain only latin (ASCII) letters or numbers: incorrectname3 Error

[CLASS_NAME_INCORRECT] class/enum/interface name should be in PascalCase and should contain only latin (ASCII) letters or numbers: incorrectname3

Check failure

Code scanning / ktlint

[EXCEPTION_SUFFIX] all exception classes should have "Exception" suffix: incorrectname3 Error

[EXCEPTION_SUFFIX] all exception classes should have "Exception" suffix: incorrectname3

Check failure

Code scanning / ktlint

[WRONG_WHITESPACE] incorrect usage of whitespaces for code separation: : should have 1 space(s) before and 1 space(s) after, but has 0 space(s) before Error

[WRONG_WHITESPACE] incorrect usage of whitespaces for code separation: : should have 1 space(s) before and 1 space(s) after, but has 0 space(s) before
fun INCORRECT_FUNCTION() {
throw Exception()
}

// fun myCommentedFunction() {
// }

Expand Down
Loading