Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some optimization to tooltip parsing #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Some optimization to tooltip parsing #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions OutfitterInventory.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,27 +368,25 @@ function Outfitter._ItemInfo:GetItemInfoFromLink(itemLink)
end

function Outfitter._ItemInfo:ParseTooltip()
-- Grab a tooltip
local tooltip = Outfitter.TooltipLib:SharedTooltip()
tooltip:ClearLines()
local data
if self.Location and self.Location.BagIndex then
tooltip:SetBagItem(self.Location.BagIndex, self.Location.BagSlotIndex)
data = C_TooltipInfo.GetBagItem(self.Location.BagIndex, self.Location.BagSlotIndex)
elseif self.Location and self.Location.SlotID then
tooltip:SetInventoryItem("player", self.Location.SlotID)
data = C_TooltipInfo.GetInventoryItem("player", self.Location.SlotID)
elseif self.Link then
tooltip:SetHyperlink(self.Link)
data = C_TooltipInfo.GetHyperlink(self.Link)
else
assert(false, "can't find item for tooltip")
return
end

-- Return if something went wrong
if not tooltip:IsShown() then
if not data or not data.lines then
return
end

-- Iterate the lines of the tooltip
for line in Outfitter.TooltipLib:TooltipLines(tooltip) do
for _, line in ipairs(data.lines) do
self:ParseTooltipLine(line.leftText, line.leftColor)
end

Expand Down