Detect zlibstatic.lib when building for Windows#44
Closed
radarhere wants to merge 1 commit intonulano:zlib-ngfrom
Closed
Detect zlibstatic.lib when building for Windows#44radarhere wants to merge 1 commit intonulano:zlib-ngfrom
radarhere wants to merge 1 commit intonulano:zlib-ngfrom
Conversation
3 tasks
radarhere
force-pushed
the
zlibstatic
branch
from
ef3d571 to
646347d
Compare
radarhere
force-pushed
the
zlibstatic
branch
from
646347d to
bfd2005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#8500
If zlib-ng creates zlibstatic.lib by default, then wouldn't it seem helpful to detect that in setup.py, in case a user had built it themselves?