Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1151 - Fix artist image consistency and fallback logic #1722

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

u7630748
Copy link
Contributor

@u7630748 u7630748 commented Oct 16, 2024

Description

This PR addresses an inconsistency in the artist image display between the search results and the individual artist view. Previously, the artist's picture was visible in the search results but not on the artist's dedicated page. The solution implements a fallback mechanism to reuse the background image when only one image is available.

fix #1151

Changes Made

  • Implemented a fallback mechanism to ensure the artist image is displayed on the artist's page when only one image is available.
  • Updated the rendering logic to check for the availability of multiple images.

Screenshots

Original Search Results (with thumbnail displayed):
Original Search Result 1
Original Search Result 2

After Modifications (Search Page):
Modified Search Page

Artist Page (After Modifications):
Artist Page

Testing

  • Run the linter and passed
  • Run the npm test and passed

onamdumbare and others added 2 commits October 15, 2024 12:04
Ensures cover image (if available) is the first item - Adds thumbnail as second item for artist's profile picture
@nukeop
Copy link
Owner

nukeop commented Oct 16, 2024

Thanks, looks like this works well enough.

@nukeop nukeop merged commit 0697afc into nukeop:master Oct 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artist profile pictures may not always display on Audius pages
3 participants