Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1554: Center Play/Pause Button #1589

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

ajkapala21
Copy link
Contributor

Fixes #1544
Adds a right margin of 4px to the player button class which successfully centers each icon (pause, play, or loading). Although a previous comment highlighted that each icon was off center by a varying amount, from my inspection they are all off by the same amount, so the same margin can be applied to all of them.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (3764ff6) to head (7bf5b5f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1589   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files         362      362           
  Lines        6746     6746           
  Branches      498      498           
=======================================
  Hits         4861     4861           
  Misses       1478     1478           
  Partials      407      407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Repository owner deleted a comment from nuki-chan bot Apr 14, 2024
@nukeop
Copy link
Owner

nukeop commented Apr 14, 2024

Nice, thank you.

@nukeop nukeop merged commit a7fc3db into nukeop:master Apr 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play/Pause button not centred
2 participants