Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bandcamp plugin search aborting after the first page #1548

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

sferra
Copy link
Contributor

@sferra sferra commented Feb 10, 2024

The Bandcamp plugin aborts the search after the first page of results because of an incorrect check.
I found this bug while writing tests for an improvement/issue in the Bandcamp plugin and thought that it's better to submit it separately.

@nukeop
Copy link
Owner

nukeop commented Feb 10, 2024

Thanks, this must have changed since it was last implemented.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (52827b6) 71.40% compared to head (b398982) 71.58%.

❗ Current head b398982 differs from pull request most recent head b8e60f3. Consider uploading reports for the commit b8e60f3 to get more accurate results

Files Patch % Lines
packages/core/src/plugins/stream/BandcampPlugin.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   71.40%   71.58%   +0.17%     
==========================================
  Files         364      364              
  Lines        6707     6707              
  Branches      479      479              
==========================================
+ Hits         4789     4801      +12     
+ Misses       1524     1512      -12     
  Partials      394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nukeop nukeop self-requested a review February 10, 2024 23:19
@sferra
Copy link
Contributor Author

sferra commented Feb 10, 2024

You're welcome. Please let me know if I have to adapt the tests, because I intend to submit an additional fix and extend them to cover 2 new internal functions.

Repository owner deleted a comment from nuki-chan bot Feb 10, 2024
@nukeop
Copy link
Owner

nukeop commented Feb 10, 2024

This test format looks good to me and is consistent with the rest of the codebase.

@nukeop nukeop merged commit 0c7c69a into nukeop:master Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants