Added [Experimental] warning to SaveMeshesInScene, along with additional fixes to make it less likely to break #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em to work 100% of the time. Also reversed the checkbox logic so it's something that's being ENABLED rather than being DISABLED.
Author
|
Had to recreate the pull request since the previous one got killed by my branch rename |
… Playmode. Done by not removing the CSG components OnBuild.
Author
|
Added an extra commit to attempt to fix the Playmode usability of the new option. Basically, don't remove any CSGnodes if the option is enabled. |
…ce.SaveMeshesInSceneFiles is off, instead just hide them
…eMeshesInSceneFiles option was turned off. We now make sure that External is populated on entering playmode, and force the meshes to check that they have been rebuilt.
…esn't break scene changes.
Author
|
Think I've gotten to the bottom of the strangeness with this feature now.
|
Zallist
changed the title
|
Tested and working on 2020.3 and 2021.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added [Experimental] warning to SaveMeshesInScene since it doesn't seem to work 100% of the time. Also reversed the checkbox logic so it's something that's being ENABLED rather than being DISABLED.
Thank
gawi.#0145for letting me know that it DOES have problems. Since I've been using it for 3 months and had none, but seemingly it acts weirdly (doesn't always regenerate the meshes). This MIGHT be due to them running on Unity 2020.3. Haven't had chance to investigate.Flipping the toggle does make sense regardless, for the sake of UX. Enabling a feature rather than disabling the default.