-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling for Rust and Python #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 94.64% 94.98% +0.33%
==========================================
Files 10 11 +1
Lines 766 777 +11
==========================================
+ Hits 725 738 +13
+ Misses 41 39 -2
Continue to review full report at Codecov.
|
aac9775
to
181c1dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Based on top of #41
Fixes #20
Fixes #31
Result
instead ofOption
in Rust methods__eq__()
,__hash__()
and__repr__()
too where appropriate (using the newHasSerializableBackend
helper)