Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support Managed Load Balancer Day 4 #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Support Managed Load Balancer Day 4 #52

wants to merge 3 commits into from

Conversation

hico-horiuchi
Copy link
Contributor

@hico-horiuchi hico-horiuchi commented Mar 25, 2025 •
edited
Loading

This pull request supports Managed Load Balancer Day 4.

  • 1889fb5 : Update comments according to API reference
  • dbddbd1 : Support Managed Load Balancer Day 4

Reference

nttcom/terraform-provider-ecl#132

Related Pull Requests

Test Results

v2 
$ cd v2/ecl/managed_load_balancer/v1
$ go test ./... -count=1
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/certificates	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/certificates/testing	0.714s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/health_monitors	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/health_monitors/testing	0.584s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/listeners	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/listeners/testing	0.219s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/load_balancers	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/load_balancers/testing	0.403s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/operations	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/operations/testing	0.886s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/plans	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/plans/testing	1.061s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/policies	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/policies/testing	1.169s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/routes	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/routes/testing	1.272s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/rules	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/rules/testing	1.242s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/system_updates	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/system_updates/testing	1.230s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/target_groups	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/target_groups/testing	1.222s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/tls_policies	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/tls_policies/testing	1.217s
v3 
$ cd v3/ecl/managed_load_balancer/v1
$ go test ./... -count=1
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/certificates	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/certificates/testing	0.974s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/health_monitors	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/health_monitors/testing	0.227s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/listeners	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/listeners/testing	0.821s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/load_balancers	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/load_balancers/testing	1.147s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/operations	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/operations/testing	0.411s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/plans	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/plans/testing	0.610s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/policies	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/policies/testing	1.144s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/routes	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/routes/testing	1.229s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/rules	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/rules/testing	1.116s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/system_updates	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/system_updates/testing	1.182s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/target_groups	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/target_groups/testing	1.120s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/tls_policies	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/tls_policies/testing	1.175s
v4 
$ cd v4/ecl/managed_load_balancer/v1
$ go test ./... -count=1
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/certificates	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/certificates/testing	0.597s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/health_monitors	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/health_monitors/testing	0.429s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/listeners	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/listeners/testing	0.783s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/load_balancers	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/load_balancers/testing	0.959s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/operations	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/operations/testing	0.239s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/plans	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/plans/testing	1.140s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/policies	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/policies/testing	1.166s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/routes	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/routes/testing	1.311s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/rules	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/rules/testing	1.137s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/system_updates	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/system_updates/testing	1.146s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/target_groups	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/target_groups/testing	1.084s
?   	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/tls_policies	[no test files]
ok  	github.com/nttcom/eclcloud/v4/ecl/managed_load_balancer/v1/tls_policies/testing	1.154s

@hico-horiuchi hico-horiuchi force-pushed the support_managed_load_balancer_day_4 branch from d7a5216 to f2779b1 Compare March 25, 2025 16:22
hico-horiuchi
hico-horiuchi commented Mar 25, 2025
View reviewed changes
.github/workflows/test.yml
with:
go-version: ${{ matrix.go-version }}

- name: Checkout code
uses: actions/checkout@v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/cache v1-v2 and actions/toolkit cache package closing down

hico-horiuchi
hico-horiuchi commented Mar 25, 2025
View reviewed changes
.github/workflows/test.yml
Comment on lines -20 to -26
- name: Cache modules
uses: actions/cache@v1
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching dependency files and build outputs

@hico-horiuchi hico-horiuchi force-pushed the support_managed_load_balancer_day_4 branch from 1019ecf to cc1768a Compare March 26, 2025 07:30
@hico-horiuchi hico-horiuchi mentioned this pull request Mar 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hico-horiuchi