Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H323: improve detection and avoid false positives #2432

Merged
merged 1 commit into from
May 11, 2024
Merged

H323: improve detection and avoid false positives #2432

merged 1 commit into from
May 11, 2024

Conversation

IvanNardi
Copy link
Collaborator

@IvanNardi IvanNardi commented May 9, 2024 •
edited
Loading

No description provided.

@0xA50C1A1
Copy link
Contributor

0xA50C1A1 commented May 10, 2024 •
edited
Loading

Hi, I was just reworking this dissector :) Here is my solution if you want to take a look

h323_patch.zip

@IvanNardi
Copy link
Collaborator Author

Hi, I was just reworking this dissector :) Here is my solution if you want to take a look

h323_patch.zip

Welcome back!! I'll look into that later, thanks!

@0xA50C1A1
Copy link
Contributor

0xA50C1A1 commented May 10, 2024 •
edited
Loading

Hi, I was just reworking this dissector :) Here is my solution if you want to take a look
h323_patch.zip

Welcome back!! I'll look into that later, thanks!

Yeah, finally the support figured out what was wrong and removed the restrictions from me.

@IvanNardi
Copy link
Collaborator Author

Hi, I was just reworking this dissector :) Here is my solution if you want to take a look
h323_patch.zip

Welcome back!! I'll look into that later, thanks!

I integrated your changes, but I kept the check on the udp ports

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IvanNardi IvanNardi changed the title H323: avoid false positives H323: improve detection and avoid false positives May 11, 2024
@IvanNardi IvanNardi merged commit 0110623 into ntop:dev May 11, 2024
33 checks passed
@IvanNardi IvanNardi deleted the h323 branch May 11, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utoni utoni utoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanNardi @0xA50C1A1 @utoni