Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Path of Exile protocol dissector #2337

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Path of Exile is a free-to-play online Action RPG.

@0xA50C1A1 0xA50C1A1 closed this Mar 6, 2024
@0xA50C1A1 0xA50C1A1 reopened this Mar 6, 2024
@0xA50C1A1
Copy link
Contributor Author

again this bug #2258

@IvanNardi
Copy link
Collaborator

The two issues (fuzzing and windows) are un-related to this PR...

@0xA50C1A1
Copy link
Contributor Author

The two issues (fuzzing and windows) are un-related to this PR...

Yeah, I noticed.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor issue.

doc/protocols.rst Outdated Show resolved Hide resolved
@0xA50C1A1 0xA50C1A1 requested a review from IvanNardi March 6, 2024 18:32
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
278 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@IvanNardi IvanNardi merged commit e294904 into ntop:dev Mar 6, 2024
23 of 33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-app/path-of-exile branch March 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants