Add ISO 9506-1 MMS protocol dissector #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
utoni
reviewed
Dec 1, 2023
| (get_u_int16_t(packet->payload, 2) == htons(packet->payload_packet_len))) | ||
| { | ||
| if (current_pkt_from_client_to_server(ndpi_struct, flow)) { | ||
| /* Check COTP and ISO 8327-1 headers */ |
There was a problem hiding this comment.
Did you try the subprotocol feature?
AFAIS, it may not work with your code. But LGTM anyway.
utoni
approved these changes
Dec 1, 2023
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Describe changes:
Add support for the ISO 9506-1 MMS (Manufacturing Message Specification) protocol detection.