Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schneider Electric’s UMAS detection support #2180

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Add Schneider Electric’s UMAS detection support #2180

merged 3 commits into from
Nov 28, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

UMAS is a Modbus-based proprietary protocol (or extension?) from Schneider Electric, used in their PLCs. Huh, adding support for this turned out to be quite trivial, as SE reserved a special Modbus function code for UMAS.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small issue

src/lib/protocols/modbus.c Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IvanNardi
Copy link
Collaborator

@utoni [unrelated to this PR] could you take a look at the error when downloading the gambling sites list, please? The HTML page might be different now and we might need to update the sed command...

@IvanNardi IvanNardi merged commit c60c037 into ntop:dev Nov 28, 2023
32 of 33 checks passed
@IvanNardi
Copy link
Collaborator

Thanks!

@utoni
Copy link
Collaborator

utoni commented Nov 28, 2023

@utoni [unrelated to this PR] could you take a look at the error when downloading the gambling sites list, please? The HTML page might be different now and we might need to update the sed command...

will do

@IvanNardi
Copy link
Collaborator

@utoni [unrelated to this PR] could you take a look at the error when downloading the gambling sites list, please? The HTML page might be different now and we might need to update the sed command...

will do

Thanks!

@0xA50C1A1 0xA50C1A1 deleted the improve/add-umas-detection branch November 28, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants