Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ether-S-I/O protocol dissector #2174

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add Ether-S-I/O protocol dissector #2174

merged 1 commit into from
Nov 27, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Ether-S-I/O is a proprietary protocol used by Saia-Burgess's PLCs.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@0xA50C1A1
Copy link
Contributor Author

Here we go again...

(2) Downloading Gambling Sites (Poland)
-:16: parser error : Opening and ending tag mismatch: meta line 5 and head
</head>
       ^
-:48: parser error : StartTag: invalid element name
<!DOCTYPE html>
 ^
-:75: parser error : Opening and ending tag mismatch: head line 3 and html
</html>
       ^
-:76: parser error : Premature end of data in tag html line 2

^

@IvanNardi
Copy link
Collaborator

Here we go again...

(2) Downloading Gambling Sites (Poland)
-:16: parser error : Opening and ending tag mismatch: meta line 5 and head
</head>
       ^
-:48: parser error : StartTag: invalid element name
<!DOCTYPE html>
 ^
-:75: parser error : Opening and ending tag mismatch: head line 3 and html
</html>
       ^
-:76: parser error : Premature end of data in tag html line 2

^

Yeah, I don't know why this download keeps failing so often... Anyway, you can ignore this error (now and in the future): I will take care of it when merging...

@IvanNardi IvanNardi merged commit ebb1bc2 into ntop:dev Nov 27, 2023
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-dissector/ethersio branch November 27, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xA50C1A1 @IvanNardi