Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Omron FINS protocol dissector #2172

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Add Omron FINS protocol dissector #2172

merged 5 commits into from
Nov 27, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Factory Interface Network Service (FINS) is a network protocol used by Omron PLCs.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor issue

tests/cfgs/default/result/fins.pcap.out Outdated Show resolved Hide resolved
tests/cfgs/default/result/fins.pcap.out Outdated Show resolved Hide resolved
tests/cfgs/default/result/fins.pcap.out Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@0xA50C1A1
Copy link
Contributor Author

Just a minor issue

Ok, I've deleted those empty flows

@IvanNardi IvanNardi merged commit 84427b0 into ntop:dev Nov 27, 2023
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-dissector/omron-fins branch November 27, 2023 16:10
@IvanNardi
Copy link
Collaborator

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants