Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ndpi_domain_classify_finalize() function #2084

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

IvanNardi
Copy link
Collaborator

@IvanNardi IvanNardi commented Sep 12, 2023

The "domain classify" data structure is immutable, because it uses "bitmap64".
Allow to finalize it before starting to process packets (i.e. before calling ndpi_domain_classify_contains()) to avoid, in the data-path, all the memory allocations due to compression.

Calling ndpi_domain_classify_finalize() is optional.

The "domain classify" data structure is immutable, since it uses
"bitmap64".
Allow to finalize it before starting to process packets (i.e. before
calling `ndpi_domain_classify_contains()`) to avoid, in the data-path,
all the memory allocations due to compression.

Calling `ndpi_domain_classify_finalize()` is optional.
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lucaderi lucaderi merged commit c5cd4df into ntop:dev Sep 12, 2023
33 checks passed
@lucaderi
Copy link
Member

Thank you: it is a good addition to the existing API

@IvanNardi IvanNardi deleted the ndpi_domain_classify_finalize branch September 12, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants