Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included Gambling website data from the Polish hazard.mf.gov.pl list #2041

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Included Gambling website data from the Polish hazard.mf.gov.pl list #2041

merged 3 commits into from
Jul 14, 2023

Conversation

snicket2100
Copy link
Contributor

The list contains over 30k gambling website hostnames as of today.

@IvanNardi IvanNardi requested review from utoni and lucaderi July 11, 2023 15:24
@snicket2100
Copy link
Contributor Author

Hmm, it looks like there is no xmllint in the build environment. I wanted to avoid using sed for parsing the xml file, but I can as well do it if it turns out to be lesser evil...

@utoni
Copy link
Collaborator

utoni commented Jul 11, 2023 •
edited
Loading

Can you provide any source of the collected gambling sites?

utoni
utoni requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more information required

@snicket2100
Copy link
Contributor Author

It's a Polish national gambling website blocklist, the API is documented here https://hazard.mf.gov.pl/Content/files/Rejestr_Stron%20Hazardowych_Specyfikacja_WeWy_v1-2.pdf, unfortunately it's in Polish :/ But the list is quite extensive (over 30k entries) and also updated almost on daily basis so I thought it may be helpful.

@IvanNardi
Copy link
Collaborator

IvanNardi commented Jul 12, 2023 •
edited
Loading

Hmm, it looks like there is no xmllint in the build environment. I wanted to avoid using sed for parsing the xml file, but I can as well do it if it turns out to be lesser evil...

@snicket2100 , you can simply add "libxml2-utils" at line 56 of .github/workflows/build.yml

@snicket2100
Refreshed the Belgium Gambling Site list data
c081656 
Unfortunately some hostnames have been removed from that list,
which means they are disappearing from the `ndpi_gambling_match.c.inc`
file as well.
@snicket2100
build: added libxml2-utils (for xmllint)
7ddcc0d
@snicket2100
Included Gambling website data from the Polish hazard.mf.gov.pl list
b660a6e 
The list contains over 30k gambling website hostnames as of today.
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 33438 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utoni utoni self-requested a review July 12, 2023 07:45
@IvanNardi IvanNardi merged commit abee1a2 into ntop:dev Jul 14, 2023
33 checks passed
@IvanNardi
Copy link
Collaborator

Thanks for the contribution

@snicket2100 snicket2100 deleted the more-gambling-sites branch July 14, 2023 13:26
@utoni utoni mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utoni utoni utoni approved these changes

@IvanNardi IvanNardi IvanNardi approved these changes

@lucaderi lucaderi Awaiting requested review from lucaderi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snicket2100 @utoni @IvanNardi