-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitcoing protocol dissector. #1992
Conversation
mmaatuq
commented
May 27, 2023
- remove bitcoin protcol detection from mining.c
- add a new bitcoin deissector.
- add a new category: Cryptocurrency.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it seems fine. Just some notes:
- could you update
doc/protocols.rst
with this new protocol? - could you update the unit tests results now? This way it is simpler to check for any regressions...
- I don't know if there already is a sample of bitcoin traffic in the tests. If not, could you add it, please?
- missing file in the Windows build...
Ok, will add the required changes. |
@utoni, is it fine for you? |
@IvanNardi, @utoni,
|
* remove bitcoin protcol detection from mining.c * add a new bitcoin deissector. * add a new category: Cryptocurrency. Signed-off-by: Mahmoud Maatuq <[email protected]>
Signed-off-by: Mahmoud Maatuq <[email protected]>
Signed-off-by: Mahmoud Maatuq <[email protected]>
Add notes on the difference between normal bitcoin protocol and the mining protocol. Signed-off-by: Mahmoud Maatuq <[email protected]>
Signed-off-by: Mahmoud Maatuq <[email protected]>
d4f5523
to
81248bd
Compare
Kudos, SonarCloud Quality Gate passed! |
Usually you need to rebase to have your changes on top of latest dev |
Thank you for your contribution |