Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classification-by-ip in ndpi_detection_giveup #1981

Merged
merged 1 commit into from
May 17, 2023

Commits on May 16, 2023

  1. Fix classification-by-ip in ndpi_detection_giveup

    Return the "classification-by-ip" as protocol results only if no other
    results are available.
    In particular, never return something like
    "protocol_by_port/protocol_by_ip" (i.e. `NTP/Apple`,
    BitTorrent/GoogleCloud`, `Zoom/AWS`) because this kind of classification
    is quite confusing, if not plainly wrong.
    
    Notes:
    * the information about "classification-by-ip" is always available, so
    no information is lost with this change;
    * in the unit tests, the previous classifications with confidence
    `NDPI_CONFIDENCE_DPI_PARTIAL` were wrong, as noted in ntop#1957
    IvanNardi committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a3525be View commit details
    Browse the repository at this point in the history