Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved missing usage of nDPIs malloc wrapper. Fixes #1978. #1979

Merged
merged 1 commit into from
May 20, 2023
Merged

Improved missing usage of nDPIs malloc wrapper. Fixes #1978. #1979

merged 1 commit into from
May 20, 2023

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented May 16, 2023

  • added CI check

@utoni utoni force-pushed the improved/libc-malloc-wrapper-and-checks branch from 5e6a9e0 to 3181610 Compare May 16, 2023 13:26
@utoni utoni marked this pull request as draft May 16, 2023 13:45
@utoni utoni linked an issue May 16, 2023 that may be closed by this pull request
Invalid free() in nDPI's serializer interface. #1978
Closed
@utoni utoni force-pushed the improved/libc-malloc-wrapper-and-checks branch 14 times, most recently from d5bbbd2 to 24a45b4 Compare May 19, 2023 19:42
@utoni utoni marked this pull request as ready for review May 19, 2023 19:43
@utoni utoni requested a review from IvanNardi May 19, 2023 19:43
@utoni utoni force-pushed the improved/libc-malloc-wrapper-and-checks branch from 24a45b4 to 91843d5 Compare May 19, 2023 19:53
IvanNardi
IvanNardi requested changes May 20, 2023
View reviewed changes
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor issue, but it is a useful work!

.github/workflows/build.yml Outdated Show resolved Hide resolved
utils/check_symbols.sh Show resolved Hide resolved
@utoni utoni force-pushed the improved/libc-malloc-wrapper-and-checks branch from 91843d5 to c58c83e Compare May 20, 2023 13:14
@utoni utoni requested a review from IvanNardi May 20, 2023 13:15
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utoni utoni merged commit 5e8f93c into ntop:dev May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid free() in nDPI's serializer interface.
2 participants
@utoni @IvanNardi