Add "Heroes of the Storm" video game signature detection.

[nikitamishagin]

In this change, I've added signature detection for the "Heroes of the Storm" video game. Many nested conditions help distinguish it from other similar games. Tested on six different traffic dumps.

[IvanNardi]

Please add one trace into tests/cfgs/default/pcaps/ with some examples of flows triggering the various patterns and then update the unit tests results

[nikitamishagin]

Please add one trace into tests/cfgs/default/pcaps/ with some examples of flows triggering the various patterns and then update the unit tests results

I'll try to add testing soon. But I'm not entirely clear what else needs to be done besides adding a traffic trace to /tests/cfgs/default/pcap/?

[IvanNardi]

Please add one trace into tests/cfgs/default/pcaps/ with some examples of flows triggering the various patterns and then update the unit tests results

I'll try to add testing soon. But I'm not entirely clear what else needs to be done besides adding a traffic trace to /tests/cfgs/default/pcap/?

Run the tests via ./tests/do.sh and update any results

[IvanNardi]

Please, note that you have to add hots.c to some list in windows/nDPI.vcxproj to fix the Windows CI job

[nikitamishagin]

Trace added, results updated, hots.c added to windows/nDPI.vcxproj.

[IvanNardi]

Trace added, results updated, hots.c added to windows/nDPI.vcxproj.

One final step. As you can notice from CI results, you need to update some unit tests results. Everything will be fine when tests\do.sh will no complain anymore (on your machine)

EDIT: before that, please rebase

[nikitamishagin]

One final step. As you can notice from CI results, you need to update some unit tests results. Everything will be fine when tests\do.sh will no complain anymore (on your machine)

EDIT: before that, please rebase

I see many errors in ci "Build/macos-12 x86_64 cc --with-pcre --with-maxminddb(pull_request)". But I can't understand why they appeared. Could you suggest what is the problem?

[IvanNardi]

One final step. As you can notice from CI results, you need to update some unit tests results. Everything will be fine when tests\do.sh will no complain anymore (on your machine)
EDIT: before that, please rebase

I see many errors in ci "Build/macos-12 x86_64 cc --with-pcre --with-maxminddb(pull_request)". But I can't understand why they appeared. Could you suggest what is the problem?

You need to update the tests results under tests/cfgs/*/results. At that point the fastest way is: remove all *.out files (from all the sub-folders) ; run tests/do.sh.

[IvanNardi]

You need to update the tests results under tests/cfgs/*/results. At that point the fastest way is: remove all *.out files (from all the sub-folders) ; run tests/do.sh.

@nikitamishagin, if you prefer, we can take care of that ourselves during the merge...

[nikitamishagin]

You need to update the tests results under tests/cfgs/*/results. At that point the fastest way is: remove all *.out files (from all the sub-folders) ; run tests/do.sh.

I did everything as you indicated. But there are 2 errors while reading the pcap file.

nikitamishagin, if you prefer, we can take care of that ourselves during the merge...

It is perfectly! Please correct me, because you definitely understand better than me what needs to be done)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[IvanNardi]

You need to update the tests results under tests/cfgs/*/results. At that point the fastest way is: remove all *.out files (from all the sub-folders) ; run tests/do.sh.

I did everything as you indicated. But there are 2 errors while reading the pcap file.

nikitamishagin, if you prefer, we can take care of that ourselves during the merge...

It is perfectly! Please correct me, because you definitely understand better than me what needs to be done)

For the next time, in the README file:

* Be sure to have nBPF support, cloning PF_RING in the same directory where you cloned nDPI: git clone https://github.com/ntop/PF_RING/ && cd PF_RING/userland/nbpf && ./configure && make
* From the nDPI root directory, ./autogen.sh --with-pcre (nBPF and PCRE are usually optional, but they are needed to run/update all the unit tests)

[IvanNardi]

@nikitamishagin , thanks for your contribution!