Simplify `ndpi_internal_guess_undetected_protocol()` #1941

IvanNardi · 2023-04-11T17:38:47Z

ndpi_guess_undetected_protocol()/ndpi_internal_guess_undetected_protocol() is a strange function:

it is exported by the library and it is actively used by ntopng
it is intrinsecally ipv4-only
it returns basically something like "classification_by_ip"/"classification_by_port" (these information have already been calculated in ndpi_do_guess()...)
it access the bittorrent LRU caches (similarly to ndpi_detection_giveup() but without all the other caches...)

So:

make the interface IPv4/6 agnostic
use the classifications already available

This work will allow to make the Bittorrent caches IPV6-aware (see 81e1ea5).

Handle Dropbox classification "by-port" in the "standard" way.

`ndpi_guess_undetected_protocol()/ndpi_internal_guess_undetected_protocol()` is a strange function: * it is exported by the library and it is actively used by `ntopng` * it is intrinsecally ipv4-only * it returns basically something like "classification_by_ip"/"classification_by_port" (these information have already been calculated in `ndpi_do_guess()`...) * it access the bittorrent LRU caches (similarly to `ndpi_detection_giveup()` but without all the other caches...) So: * make the interface IPv4/6 agnostic * use the classifications already available This work will allow to make the Bittorrent caches IPV6-aware (see 81e1ea5). Handle Dropbox classification "by-port" in the "standard" way.