Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple ndpiReader configurations #1931

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

IvanNardi
Copy link
Collaborator

@IvanNardi IvanNardi commented Apr 3, 2023

Extend internal unit tests to handle multiple configurations. As some examples, add tests about:

  • disabling some protocols
  • disabling Ookla aggressiveness

Every configurations data is stored in a dedicated directory under
tests\cfgs

@IvanNardi
Copy link
Collaborator Author

@utoni, is there a better way to handle all these relative paths?

@IvanNardi IvanNardi requested a review from utoni April 3, 2023 20:12
@IvanNardi IvanNardi force-pushed the do-sh-multiple-configurations branch 4 times, most recently from 2df35dc to 3de30e1 Compare April 4, 2023 16:11
Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be coming handy.

Extend internal unit tests to handle multiple configurations.
As some examples, add tests about:
* disabling some protocols
* disabling Ookla aggressiveness

Every configurations data is stored in a dedicated directory under
`tests\cfgs`
@IvanNardi IvanNardi force-pushed the do-sh-multiple-configurations branch from 3de30e1 to 9f2f822 Compare April 6, 2023 07:46
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IvanNardi IvanNardi merged commit 7714507 into ntop:dev Apr 6, 2023
@IvanNardi IvanNardi deleted the do-sh-multiple-configurations branch April 6, 2023 09:30
@utoni
Copy link
Collaborator

utoni commented Apr 9, 2023

@utoni, is there a better way to handle all these relative paths?

dunno any better way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants