Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with GCC-7 and latest RoaringBitmap code #1886

Merged
merged 1 commit into from
Feb 13, 2023

Commits on Feb 13, 2023

  1. Fix compilation with GCC-7 and latest RoaringBitmap code

    Latest RoaringBitmap version (introduced with bf413af) triggers a new
    warning with GCC-7:
    
    ```
    ivan@ivan-Latitude-E6540:~/svnrepos/nDPI(dev)$ CC=gcc-7 CXX=g++-7 ./autogen.sh && make -s
    autoreconf: Entering directory `.'
    [...]
    third_party/src/roaring.c:1815:1: warning: ‘no_sanitize’ attribute directive ignored [-Wattributes]
     static inline int array_container_cardinality(const array_container_t *array) {
     ^~~~~~
    third_party/src/roaring.c:1964:5: warning: ‘no_sanitize’ attribute directive ignored [-Wattributes]
         const array_container_t *container2) {
    [..]
    ```
    
    The core issue is that `no_sanitize` attribute is defined only for GCC
    >= 8.
    That breaks the CI since we still use GCC-7 and `-Werror`: add a simple
    workaround.
    
    Fix compilation on Windows
    IvanNardi committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    c3731ac View commit details
    Browse the repository at this point in the history