QUIC: handle retransmissions and overlapping fragments in reassembler (#1195) #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the CI tests didn't run? |
|
Had the same issue with PR #1491 recently. Is there any Github Actions Quota? |
|
Probably a scheduled maintenance for GitHub Actions.
|
|
@viniciussn, could you push a new version (with some trivial changes) to hopefully trigger the CI, please? |
IvanNardi
requested changes
Mar 25, 2022
|
I'm going to run some tests. I'll update you |
IvanNardi
requested changes
Apr 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
IvanNardi
approved these changes
Apr 7, 2022
|
Thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to handle the two remaining cases in QUIC reassembler: retransmissions and overlapping fragments.