-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #1303
Improve CI #1303
Conversation
@lnslbrty note that my changes do not affect other builds etc.
|
@aouinizied : I am not sure what's going on, but CI didn't run on your PR... |
@IvanNardi I think this is normal as it's a PR changing the CI file. |
|
I do not see any arm or mingw builds. What happened? // EDIT: The first two jobs build for mingw. Is it possible to rename jobs? instead of |
Name generation will be tricky. However I changed the script. Now, cross compilation is triggered for all ubuntu jobs and I added a notice to the step name displayed to make it more clear. EDIT: Now reverted to ubuntu-latest only as compilation with mingw fails on ubuntu 18.04 with |
@lnslbrty Travis dropped and badge icon replaced. |
Explicit linkage of |
@lnslbrty it was probably a dummy fix for some windows CI I was trying to setup. Removed it and now it works on both. Thanks for your help. |
Is it possible to test multiple compilers, as suggested earlier? |
I would like to see While compiling for |
@IvanNardi Yes, need to set it up. But we must implement at least 2 versions on each target for 2 compilers. I will rather make it part of the matrix. It will result in 24 jobs (8 current jobs * 4 versions (2 of CLANG and 2 of GCC let's say)) but this is not an issue as GitHub actions are limited to 255 jobs per matrix (AFAIK). @lnslbrty We will have mainly two options if you want to build and test on arm using Github Actions:
Zied |
While the first option sounds interesting and I will probably try it out for my own projects, for |
@aouinizied There are also some (not serious) |
@IvanNardi @lnslbrty I added jobs on Ubuntu Latest using the following old and new versions logic:
We continue to build on ubuntu-latest, ubuntu 18.04, macos11 and macos10.15 using the default compiler of the runner (gcc for ubuntu and clang for MacOS) I fixed the CodeInspector complaints too. As now we have improved our CI on Github Actions, Travis is definitively dropped. ARM target using Qemu and build on Windows server using MinGW will be part of a follow PR as I need to investigate several issues. Consequently, this PR can be merged as it is. Zied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
@lnslbrty Thanks for your feedbacks.
Here are some notes:
Zied |
Kudos, SonarCloud Quality Gate passed! |
@lnslbrty also dropped appveyor.yml because it is not relevant anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and very useful wok. Thanks!
This PR improves the current CI pipeline:
This PR addresses previously discussion in: #1289
Zied