Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the old Skype dissector #2166

Closed
0xA50C1A1 opened this issue Nov 24, 2023 · 2 comments
Closed

Get rid of the old Skype dissector #2166

0xA50C1A1 opened this issue Nov 24, 2023 · 2 comments

Comments

@0xA50C1A1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Skype protocol dissector is obsolete and causes false positives - #2158. #1954 - there has already been discussion under this pull request, but the broken dissector has been kept for now.

Describe the solution you'd like
Skype hasn't used P2P connections over UDP for a long time and uses TLS+STUN like every other messengers. There's no point in keeping an old Skype protocol dissector that doesn't work anymore, especially since it gives false positives on various UDP traffic.

Here is a pcap with modern Skype traffic and ndpiReader output to prove my point.
PCAP

Снимок экрана от 2023-11-24 18-11-52

@IvanNardi
Copy link
Collaborator

It might be time to push again for this old PR #1954...

IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Dec 1, 2023
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
@0xA50C1A1 0xA50C1A1 reopened this Dec 5, 2023
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Dec 9, 2023
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Dec 22, 2023
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Jan 15, 2024
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Jan 19, 2024
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Feb 10, 2024
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Feb 12, 2024
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: ntop#2166
IvanNardi added a commit that referenced this issue Feb 12, 2024
Skype has been using standard protocols (STUN/ICE or TLS) for a long,
long time, now. Long gone are the days of Skype as a distribuited
protocol.

See: #2166
@IvanNardi
Copy link
Collaborator

Done in ae36648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants