minor fixes (#2023)

fixed 'handle leak' in ndpi_load_malicious_sha1_file and removed the redundant comparison ndpi_search_eaq Co-authored-by: Ivan Kapranov <[email protected]>
ntop · Jun 22, 2023 · 15f0e14 · 15f0e14
1 parent aa25c06
commit 15f0e14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c
@@ -4258,6 +4258,8 @@ int ndpi_load_malicious_sha1_file(struct ndpi_detection_module_struct *ndpi_str,
       num++;
   }
 
+  fclose(fd);
+
   return num;
 }
 

diff --git a/src/lib/protocols/eaq.c b/src/lib/protocols/eaq.c
@@ -51,7 +51,6 @@ static void ndpi_search_eaq(struct ndpi_detection_module_struct *ndpi_struct, st
         ((sport != EAQ_DEFAULT_PORT) && (dport != EAQ_DEFAULT_PORT)) )
 	    break;
 
-    if(packet->udp != NULL) {
       u_int32_t seq = (packet->payload[0] * 1000) + (packet->payload[1] * 100) + (packet->payload[2] * 10) + packet->payload[3];
 
       if(flow->l4.udp.eaq_pkt_id == 0)
@@ -71,7 +70,7 @@ static void ndpi_search_eaq(struct ndpi_detection_module_struct *ndpi_struct, st
         return;
       } else
 	return;
-    }
+
   } while(0);
 
   NDPI_EXCLUDE_PROTO(ndpi_struct, flow);