Fix broken comparison of the generic methods

[zvirja]

Fixes #828

Currently we compare generic methods by names which is wrong in case we e.g. have shadowing via new. Do proper generic definition comparison, so that we preserve methods identity. Added tests to validate the scenarios.

[dtchepak]

@zvirja happy for me to release current main as 6.2.0?

Should i set up the nuget-push environment to require a reviewer prior to it running?

[zvirja]

I am creating 2 more PRs and we could go after that.

Should i set up the nuget-push environment to require a reviewer prior to it running?

I am not sure I follow what you mean and exactly it happens. But I would say - no, if one creates a tag, we assume one knows what they are doing, so it's okay :)

[dtchepak]

Something like this:

---

if one creates a tag, we assume one knows what they are doing, so it's okay

You seem to be forgetting I am still involved with this project and have access to create tags 😅 🤣

I take your point though; definitely less friction to just tie it to releases, I just tend to be (overly?) cautious with this stuff. 😄

[zvirja]

Something like this:

Wow, I didn't even know you could review those things 😮 So many projects I work alone on, so nice to learn 😅

I take your point though; definitely less friction to just tie it to releases, I just tend to be (overly?) cautious with this stuff. 😄

I wouldn't be much worried. Worst case scenario - we can always unlist things and bump versions to fix. I had to fix the mess so many times in my life until now, so I wouldn't worry at all. But of course we shall be reasonable in our actions 😅

[zvirja]

@dtchepak Let's proceed with merge once me merge params. We have a huge issue with generics support, especially after we got Arg.AnyType - it allows some significant violation scenarios. Especially if you start playing with covariance/contravariance. I wanted to quickly fix it, but apparently the journey is far more complicated. I may finalize it later, but it shall come either as a part of next 6.x, or we even releaes 7.x if there are required breaking changes in how generics are handled.