Skip to content

Conversation

@jheinath
Copy link
Contributor

Hey there,

regarding to @dtchepak's last comment in my recent PR (#729) I implemented his additional feature request:

I have a feature request if you get time to look at it: clicking the headings auto-copies to clipboard, but if people don't have a clipboard manager this might wipe out something they wanted to keep. It might be handy to have a "copy to clipboard" link appear on hover that will do this

preview-ui.mp4

otherwise just clicking the heading to jump to the anchor is probably sufficient (people can copy the url from the address bar).

-> still works like before, but clicking on the header itself does no longer copy to clipboard. Only possible via the tooltip.

Please kindly take a look and give your feedback! Thanks!

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm happy to merge as-is, or can apply @304NotModified's suggestion first (or in a different PR). Let me know which you prefer. 👍

@jheinath
Copy link
Contributor Author

Thanks! I'm happy to merge as-is, or can apply @304NotModified's suggestion first (or in a different PR). Let me know which you prefer. 👍

Added @304NotModified suggestion, thx for the hint! 👍

@dtchepak you may merge when it fits for you, thanks as well!

@dtchepak dtchepak merged commit c94fddc into nsubstitute:main Sep 23, 2023
dtchepak added a commit to nsubstitute/nsubstitute.github.com that referenced this pull request Sep 23, 2023
@dtchepak
Copy link
Member

Change is live. Thanks @jheinath and @304NotModified! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants