complete Foundations Mastery #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public CustomString(IEnumerable<char> contents) | ||
| { | ||
| this.Contents = contents; |
| public void Clear() | ||
| { | ||
| Contents = new List<char>(); | ||
| Contents.ToList().Clear(); |
There was a problem hiding this comment.
By default, a new List is empty, so the explicit Clear isn't technically necessary
| { | ||
| concat += a; | ||
| } | ||
| return concat; |
There was a problem hiding this comment.
Looping over each one does work - but is there a way we can treat both of them as strings (Contents and rhs)? It's less work than building them one character at a time
| inter += conList[i]; | ||
| inter += rhsList[i]; | ||
| } | ||
| return inter; |
| public string Author { get; set; } | ||
| public int DatePublished { get; set; } | ||
| public virtual int CircPeriodDay { get; } = 14; | ||
| } |
There was a problem hiding this comment.
I really like these two classes - library media are a great example of inheritance
|
This looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit pull request for exercise