This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Quiz Submission #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job on your quiz, Matt! Finally I was able to get it down and running. Just a couple of things to point out. With your form, when you are handling an event with an eventlistener you may want to prevent the default action which in the case of a form would be to submit the form. You have two different pieces of script doing the same thing, and one may defer to the other or they may both run. For a bonus you may try doing some error checking for just one character. Otherwise, everything looks good to merge after you fix your merge conflict. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up and didn't create a quiz branch right when I started (been pushing all commits to Master). I deleted those files from the Master branch but github is still recognizing the commits. Anyway, all of this code is up for review.