Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

initial files #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

initial files #1

wants to merge 11 commits into from

Conversation

csmalley89
Copy link
Collaborator

No description provided.

@ChristinaJYoung
Copy link

Great start here, however there are a few things that you should fix up.

  1. The instruction for the user is unclear. You have one text box to name your robot but nothing to name your opponent robot. However you do have to select both robots for the battle. You should set up a text box to name both robots and clearly explain to the user that they need to select both their robot and their opponent.

  2. The first time you hit the attack button you robots switch places.

  3. You shouldn't have a negative health, it should stop at 0.

  4. The user is able to keep clicking the attack button even after a winner is declared and therefore the string of text keeps populating the dom every time the button is clicked. Come up with a way to keep this from happening (possibly disabling the button)

Overall, great job, just fix these few things and let me know when I can look at it again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants