nsq_tail multi-topic and build stuff #960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with optional flag "--print-topic" to print topic name before message body
avoid "use of internal package not allowed" error in this case by forcing the import path to be as if it were the upstream repo
now works for any $GOPATH, not just $HOME/gopath
build in a golang-based container, then copy resulting binaries into a minimal alpine-based container
|
@mreiferson I could also squash all the build-related commits together if you like |
use pointers to nsq.Consumer, rather than copies of the structs otherwise they don't fully stop
|
I also added a tweak to the stopping, see the last commit @soar |
|
@ploxiln LGTM, you want to leave that last commit separate? |
|
also, I think this is another case where you could push to the original PR's branch instead? |
|
How this PR got increased coverage with same changes as mine? :-D |
|
the coverage fluctuates randomly, one of these days I'll get around to figuring out why :) |
|
I'll squash my fix in. I didn't think of the fact that I might be able to push to the original branch because I'm an |
|
I was able to force-push this to #957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just squashed and re-titled the commits from #957