Merged
Conversation
All objects must be under payload len limit, linker is no exception. Moreover, f5ffd70 added check for this. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
One of splitting tests never actually done splitting before. Now it does. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
In these tests, only relative payload len is important, not the absolute limit. Also, there is no "unknown limit" concept: the limit is always known. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Defect of e1a82c5 or 44a2cc4. Previously, slicer wrote resulting LINK object like this: 1. pass full object to `ObjectWriter.ObjectPutInit`; 2. write whole payload again to payload `io.Writer`. Thus, the output was an incorrect object due to double payload. Now LINK header is passed without payload. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
slicer-tests
branch
from
7b810f5 to
1211ce3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #725 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 164 164
Lines 20909 20909
=======================================
Hits 12317 12317
Misses 8325 8325
Partials 267 267 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
carpawell,
roman-khimov and
smallhive
as code owners
roman-khimov
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detected unexpectedly in nspcc-dev/neofs-node#3461