Fix metrics on parent objects' expiration #3717
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from 9a49cd0. Before it, deletion code strongly relied that parent objects go no-op. Then it started to treat parent objects as physically stored ones. This led to incorrect metric tracking. In particular, shard counters. This was reproduced in DevEnv: when split objects expired, metrics became: ``` neofs_node_object_counter{shard="6pmbXUjzhKuvYnzrkUbeuP",type="logic"} -9 neofs_node_object_counter{shard="6pmbXUjzhKuvYnzrkUbeuP",type="phy"} -9 neofs_node_object_counter{shard="LpCtgJvdezqupmWtbM71rJ",type="logic"} -10 neofs_node_object_counter{shard="LpCtgJvdezqupmWtbM71rJ",type="phy"} -10 neofs_node_engine_payload_size{shard="6pmbXUjzhKuvYnzrkUbeuP"} -1.048743e+06 neofs_node_engine_payload_size{shard="LpCtgJvdezqupmWtbM71rJ"} -1167 ``` Refs #3477. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/ec-expiration
branch
from
c450857 to
f27ca9f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3717 +/- ##
=======================================
Coverage 26.87% 26.87%
=======================================
Files 658 658
Lines 41808 41808
=======================================
Hits 11235 11235
+ Misses 29536 29533 -3
- Partials 1037 1040 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
roman-khimov
reviewed
Dec 4, 2025
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
An update to counters is required as a part of migration as well. We've done it once, can do it again. We certainly have some expired big objects in mainnet, it's just that it's hard to notice anything in counters given the overall number/size of objects.
| if metaBucket != nil { | ||
| phyKey := slices.Concat([]byte{metaPrefixIDAttr}, oID[:], []byte(object.FilterPhysical), objectcore.MetaAttributeDelimiter, []byte(binPropMarker)) | ||
| if metaBucket.Get(phyKey) == nil { | ||
| return false, false, 0, nil |
Member
There was a problem hiding this comment.
I don't think it's correct to leave garbageObjectsBKT entry. Also we we have a notion of available/unavailable objects and I'm not sure we're correctly handling those.
Contributor
Author
|
needs deeper examination |
cthulhu-rider
added
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.