-
Notifications
You must be signed in to change notification settings - Fork 48
metabase: use meta bucket to mark containers with GC #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1813f0 to
c7e8a89
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3561 +/- ##
==========================================
+ Coverage 25.71% 25.97% +0.25%
==========================================
Files 659 660 +1
Lines 49399 49774 +375
==========================================
+ Hits 12705 12927 +222
- Misses 35685 35808 +123
- Partials 1009 1039 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c7e8a89 to
87580b0
Compare
cthulhu-rider
requested changes
Sep 9, 2025
87580b0 to
3f78df9
Compare
3f78df9 to
1c0dae8
Compare
cthulhu-rider
approved these changes
Sep 9, 2025
1c0dae8 to
8f0905b
Compare
Drop garbage containers bucket and use meta bucket to mark containers with GC. Closes #3521. Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
roman-khimov
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3521.