Drop unused code #3559
Drop unused code #3559
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
+ Coverage 25.94% 26.48% +0.54%
==========================================
Files 660 653 -7
Lines 49712 49278 -434
==========================================
+ Hits 12898 13053 +155
+ Misses 35777 35185 -592
- Partials 1037 1040 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We can merge this one, @End-rey doesn't need it according to #3553 (comment) and otherwise of course we want to drop dead code. |
cthulhu-rider
force-pushed
the
remove/unused
branch
2 times, most recently
from
c55fcc0 to
f38c92d
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
|
test publish to NeoFS failed. https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/3979-1757674208/index.html |
| // CheckForUnknownFields validates the config struct for unknown fields with the config map. | ||
| // If the field in the config is a map of a key and some value, need to use `mapstructure:,remain` and | ||
| // `prefix` tag with the key prefix, even it is empty string. | ||
| func CheckForUnknownFields(configMap map[string]any, config any) error { |
There was a problem hiding this comment.
I'm surprised this is unused (but I do see only tests are referencing it). @End-rey?
There was a problem hiding this comment.
Now everything is done by https://pkg.go.dev/github.com/spf13/[email protected]#Viper.UnmarshalExact. Forgot to delete.
|
Looks like this will solve at least some of the nspcc-dev/.github#39 warnings. |
Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
remove/unused
branch
from
f38c92d to
f5724a4
Compare
No description provided.