Engine EC

[cthulhu-rider]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 97.36842% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.97%. Comparing base (86ea4df) to head (782ad58).
⚠️ Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/metrics/engine.go	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3534      +/-   ##
==========================================
+ Coverage   24.81%   24.97%   +0.16%     
==========================================
  Files         674      677       +3     
  Lines       50133    50201      +68     
==========================================
+ Hits        12440    12538      +98     
+ Misses      36698    36669      -29     
+ Partials      995      994       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[carpawell]

this is done only for unwrapping? will there be such real cases? cant it be more descriptive like UnreadableObject?

[cthulhu-rider]

unwrapping, yes. We often wrap IDs, like return fmt.Errorf("failed to handled object %s: %w", id, err). In some cases caller may wish to handle the ID specifically. This allows to get it for free w/o additional return statement

cant it be more descriptive like UnreadableObject?

i wanna keep it as simple as is, so that each use case can give it a special meaning

will there be such real cases?

may be, this is very generic element

[carpawell]

i meant this is used in engine pkg and returned only by shard pkg, so maybe that is a good place for it. i do understand that it can be used in the future in some other packages. but ok