Skip to content

Conversation

@cthulhu-rider
Copy link
Contributor

currently, i'm trying to implement single-level encoding. It's simpler and less resource intensive. Plus it's within current multi-level slicing restrictions like 60faa73 (smth else?)

an obvious alternative would be a two-level format, where the resulting objects of slicing by length (up to MaxObjectSize) are wrapped into new objects due to the recursive structure. I haven't found any advantages in it yet

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 71.13402% with 28 lines in your changes missing coverage. Please review.

Project coverage is 21.33%. Comparing base (23469f2) to head (166b856).
Report is 90 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/object/put/ec.go 70.96% 18 Missing and 9 partials ⚠️
pkg/services/object/put/streamer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3429      +/-   ##
==========================================
+ Coverage   20.92%   21.33%   +0.40%     
==========================================
  Files         706      708       +2     
  Lines       52809    53076     +267     
==========================================
+ Hits        11052    11325     +273     
+ Misses      40959    40915      -44     
- Partials      798      836      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider force-pushed the ec branch 12 times, most recently from c1ebce4 to 6d97375 Compare July 1, 2025 12:21
@cthulhu-rider
Copy link
Contributor Author

cthulhu-rider commented Jul 1, 2025

works overall. I tested this against SNs v0.47.1. Data shards are accepted well. Linker is denied:

  1. being sharded as other split members, its RS shards have LINK type, so SNs deny them on payload verification (code)
  2. then i tried to make its RS shards to have REGULAR type with recovery __NEOFS__EC_RS_SRC_TYPE: LINK attribute. This leads to other failure

for now im leaning towards option 1 and elimination content error in EC containers specific

@cthulhu-rider cthulhu-rider marked this pull request as ready for review July 1, 2025 13:26
@cthulhu-rider
Copy link
Contributor Author

overlapped by #3457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants