Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcsrv: set minimal default SessionExpirationTime to 5s, fix #3509 #3529

Merged
merged 1 commit into from
Jul 26, 2024
Merged

rpcsrv: set minimal default SessionExpirationTime to 5s, fix #3509 #3529

merged 1 commit into from
Jul 26, 2024

Conversation

roman-khimov
Copy link
Member

No description provided.

carpawell
carpawell approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says not less than 5 seconds, it does not less than 5 seconds. Value is understandable but i cannot say if it is good or bad.

@roman-khimov roman-khimov merged commit 4fe9597 into master Jul 26, 2024
19 checks passed
@roman-khimov roman-khimov deleted the fix-sessionexpiration-default branch July 26, 2024 14:24
AnnaShaleva
AnnaShaleva reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'd restrict it by 1s instead of 5s because I have a fear of sessions explosion in envs with small (<100ms) BlockTime and careless clients who don't close their sessions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva left review comments

@carpawell carpawell carpawell approved these changes

@AliceInHunterland AliceInHunterland Awaiting requested review from AliceInHunterland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roman-khimov @AnnaShaleva @carpawell